Re: patches for pkgsrc/multimedia/libdv

["Jeremy C. Reed" <reed@reedmedia.net>]

On Thu, 10 Feb 2005, Osamu OISHI wrote:

> > I notice this under Linux with Pkgsrc because I didn't have -O by default
> > in my CFLAGS.

> No problem occur in the following environments
> as described in libdv/README.html.
>    i386:    libdv-0.1022(NetBSD-2.0)
>    sparc64: libdv-0.1022(NetBSD-2.0)
>    sparc:   libdv-0.1022(NetBSD-2.0)

I assume this is because the -O2 is on by default as done by
/usr/share/mk/sys.mk.

> Therefore, the problem depended on your environment
> when the problem ocurred on linux.
>
> To solve the problem of an environmental dependency,
> the following description is added to libdv/Makefile.
>    .include "../../devel/pkgconfig/buildlink3.mk"
>
> At least, the change of (-O2 -> -O) decreases the execution speed
> and is harmful in the environment such as NetBSD-i386.
> And, it is not accepted to apply such a change to all the environments.

I now see that:

              If  you  use  multiple  -O options, with or without
              level numbers, the last such option is the one that
              is effective.

Would it be okay if the -O is prepended to the CFLAGS then?

> The solution with "pkgconfig" seems a better method

I don't understand how that helps.

> though it is possible to add the following descriptions
> on limited linux environment,
> if the problem is reproduced on all linux.

No it is not all Linux, I think it is on any machine build without
optimizations (like the PR I mentioned previously was for FreeBSD that
had -O removed.)

 Jeremy C. Reed

 	  	 	 technical support & remote administration
	  	 	 http://www.pugetsoundtechnology.com/