Re: -O optimization for pkgsrc/multimedia/libdv

[Osamu OISHI <oishi@ims.ac.jp>]

"Jeremy C. Reed" wrote:
> Index: multimedia/libdv/Makefile.common
> ===================================================================
> RCS file: /cvsroot/pkgsrc/multimedia/libdv/Makefile.common,v
> retrieving revision 1.3
> diff -b -u -r1.3 Makefile.common
> --- multimedia/libdv/Makefile.common    10 Aug 2005 20:56:20 -0000      1.3
> +++ multimedia/libdv/Makefile.common    18 Dec 2005 02:43:37 -0000
> @@ -30,6 +30,9 @@
>   .endif
> 
>   LIBS+=                ${LIBOSSAUDIO}
> +.if empty(CFLAGS:M-O*)
> +CFLAGS+=       -O
> +.endif

This change can be accepted when judged only from my environment (i386), 
since the expression of "if empty(CFLAGS:M-O*)" is evaluated 
after setting of the environment variable (-O2).
However, I do not have the positive proof whether this expression is evaluated 
after setting of the environment variable (-O2), in all environments. 

--
Osamu OISHI