Re: byteswap in uhci.c and ohci.c (Re: uhci on macppc)

[Tsubai Masanari <tsubai@iri.co.jp>]

>とりあえず compile 通って今までと変わらずに動くようなら

コンパイルは通って、なんとなく動いているようには見えます。
普段使っていないので全然変わらずかどうかまでは保証できません
けど。

/dev/wskbd0 を open したままで抜くと以前と挙動が変わりました。

旧:
Don't login as root, use the su command.
# cat /dev/wskbd0
uhub1: port error, restarting port 1
uhub2: at uhub1 port 1 (addr 2) disconnected
ukbd0: at uhub2 port 1 (addr 3) disconnected
wskbd0 detached
ukbd0 detached
cat: /duhub2 detached
trap type 300 at 1e1de4
Stopped in usb1 at      cpu_Debugger+0x10:      lwz r0, r1, 0x14,
db> 

新:
# cat /dev/wskbd0
uhub1: port error, restarting port 1
uhub2: at uhub1 port 1 (addr 2) disconnected
ukbd0: at uhub2 port 1 (addr 3) disconnected
wskbd0 detached
ukbd0 detached
cat: /dev/wsuhub2 detached
kbd0: Input/output error
# panic: lockmgr: no context
Stopped at      cpu_Debugger+0x10:      lwz r0, r1, 0x14,
db> 


もう一つ。

旧:
# hexdump -C /dev/wskbd0
00000000  00 00 00 02 00 00 00 2f  38 ca 37 bd 17 33 74 00  |......./8.7..3t.|
00000010  00 00 00 01 00 00 00 2f  38 ca 37 bd 1b 04 4e 38  |......./8.7...N8|
00000020  00 00 00 02 00 00 00 2f  38 ca 37 bd 30 f3 bd 00  |......./8.7.0...|
00000030  00 00 00 01 00 00 00 2f  38 ca 37 bd 35 3e 3f c0  |......./8.7.5>?.|
uhub1: port error, restarting port 1
uhub2: at uhub1 port 1 (addr 2) disconnected
ukbd0: at uhub2 port 1 (addr 3) disconnected
wskbd0 detached
ukbd0 detached
              hexdump: /dev/wskbuhub2 detached
d0: panic: lockmgr: no context
Stopped at      cpu_Debugger+0x10:      lwz r0, r1, 0x14,
db> 

新:
00000500  00 00 00 02 00 00 00 28  38 ca 37 2d 09 66 99 d8  |.......(8.7-.f..|
00000510  00 00 00 01 00 00 00 28  38 ca 37 2d 0d 37 7f c8  |.......(8.7-.7..|
uhub1: port error, restarting port 1
uhub2: at uhub1 port 1 (addr 2) disconnected
ukbd0: at uhub2 port 1 (addr 3) disconnected
wskbd0 detached
ukbd0 detached
              hexdump: ohci_close_pipe: pipe not empty sed=0xef509760 hd=0x19e76e0 tl=0x19e77d0 pipe=0xe0416700, std=0xef5196e0
/dev/wskbd0: ohci_close_pipe: pipe still not empty
uhub2 detached
panic: lockmgr: no context
Stopped at      cpu_Debugger+0x10:      lwz r0, r1, 0x14,
db> 

ohci_close_pipe() の変更によるものと思われますが、trap しちゃうのが
panic になるのはきっと正しいのだろうなあ…、たぶん。(例によってちゃ
んと読んでない)

# panic するのは正しいのか? :-)