[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: update for wip/libdv

* Jeremy C. Reed, Thu, 10 Jun 2004 11:41:07 -0700 (PDT):
> I see that tech-pkg-ja@ is the maintainer for pkgsrc-wip's libdv.
> It would not build for me due to some extern __inline__ problem with
> dv_peek_vlc. I found a solution from FreeBSD ports: an -O optimization
> must be done. (NetBSD defaults to -O2 which is fine.)
> May I commit any of the following? Or can you update wip/libdv?

Just a couple of minor comments.

> +PKGCONFIG_OVERRIDE+=     ${WRKSRC}/libdv.pc.in

I think relative paths are preferred for PKGCONFIG_OVERRIDE.

> +CONFIGURE_ARGS+=	--prefix=${PREFIX}

Isn't this redundant?

Min Sik Kim

PGP signature