[Date Prev][Date Next][Thread Prev][Thread Next][Date Index][Thread Index]

Re: update for wip/libdv

On Thu, 10 Jun 2004, Min Sik Kim wrote:

> > +PKGCONFIG_OVERRIDE+=     ${WRKSRC}/libdv.pc.in
> I think relative paths are preferred for PKGCONFIG_OVERRIDE.

I got that example as generated from url2pkg script which has:
   echo "PKGCONFIG_OVERRIDE+=      \${WRKSRC}/$i"

Many examples in pkgsrc do not use WRKSRC, but mk/bsd.pkg.mk has:
 SUBST_FILES.pkgconfig=          ${PKGCONFIG_OVERRIDE:S/^${WRKSRC}\///}
so I guess it was (or is still) alright.

> > +CONFIGURE_ARGS+=	--prefix=${PREFIX}
> Isn't this redundant?

Sorry, I forgot to mention that my patch changes the formatting. Sorry for
so many changes in one patch. I added some tabs.

The "CONFIGURE_ARGS+= --prefix=${PREFIX}" was in the original Makefile
before I patched it.

Yes, it is redundant.

 Jeremy C. Reed

 	  	 	 technical support & remote administration